:beetle: Fix bug enabling a freed node

Using signals allow to implement logics without taking care if the node
receiving it still exist or not.

godot/component/ui/input_prompts/input_prompts_center.gd

@@ -3,14 +3,24 @@ extends CenterContainer
 ## Manage the display of several inputs prompts
 
 
-@onready var WalkPrompts: Control = $InputPromptsCollection/WalkPrompts
-@onready var VehiclePrompts: Control = $InputPromptsCollection/VehiclePrompts
-@onready var JeepPrompts: Control = $InputPromptsCollection/VehiclePrompts/JeepPrompts
-@onready var PlanePrompts: Control = $InputPromptsCollection/VehiclePrompts/PlanePrompts
+signal prompt_vehicle(enable: bool)
+signal prompt_jeep(enable: bool)
+signal prompt_plane(enable: bool)
+signal prompt_walker(enable: bool)
 
 
 func _on_title_screen_start_game() -> void:
-	_enable(WalkPrompts)
+	var WalkPrompts: PromptContainer = $InputPromptsCollection/WalkPrompts
+	var VehiclePrompts: PromptContainer = $InputPromptsCollection/VehiclePrompts
+	var JeepPrompts: PromptContainer = $InputPromptsCollection/VehiclePrompts/JeepPrompts
+	var PlanePrompts: PromptContainer = $InputPromptsCollection/VehiclePrompts/PlanePrompts
+
+	prompt_walker.connect(WalkPrompts.switch)
+	prompt_vehicle.connect(VehiclePrompts.switch)
+	prompt_jeep.connect(JeepPrompts.switch)
+	prompt_plane.connect(PlanePrompts.switch)
+
+	_enable_walker_prompts()
 	_disable_vehicle_prompts()
 
 
@@ -18,37 +28,35 @@ func _on_victory_menu_visibility_changed() -> void:
 	queue_free()
 
 
-func _enable(prompts: Control) -> void:
-	prompts.set_visible(true)
-	prompts.set_process_mode(Node.PROCESS_MODE_PAUSABLE)
+func _enable_walker_prompts() -> void:
+	prompt_walker.emit(true)
 
 
-func _disable(prompts: Control) -> void:
-	prompts.set_visible(false)
-	prompts.set_process_mode(Node.PROCESS_MODE_DISABLED)
+func _disable_walker_prompts() -> void:
+	prompt_walker.emit(false)
 
 
 func _enable_vehicle_prompts_of(vehicle: SeatedVehicle) -> void:
-	_enable(VehiclePrompts)
+	prompt_vehicle.emit(true)
 
 	if vehicle is Jeep:
-		_enable(JeepPrompts)
+		prompt_jeep.emit(true)
 	if vehicle is Biplan or vehicle is TinyPlane:
-		_enable(PlanePrompts)
+		prompt_plane.emit(true)
 
 
 func _disable_vehicle_prompts() -> void:
-	_disable(JeepPrompts)
-	_disable(PlanePrompts)
+	prompt_jeep.emit(false)
+	prompt_plane.emit(false)
 
-	_disable(VehiclePrompts)
+	prompt_vehicle.emit(false)
 
 
 func _on_main_walker_got_in(vehicle: SeatedVehicle) -> void:
-	_disable(WalkPrompts)
+	_disable_walker_prompts()
 	_enable_vehicle_prompts_of(vehicle)
 
 
 func _on_main_walker_got_out() -> void:
-	_enable(WalkPrompts)
+	_enable_walker_prompts()
 	_disable_vehicle_prompts()

godot/component/ui/input_prompts/jeep/jeep_prompts.tscn

@@ -1,35 +1,41 @@
-[gd_scene load_steps=16 format=3 uid="uid://sogwc56hcxlr"]
+[gd_scene load_steps=22 format=3 uid="uid://sogwc56hcxlr"]
 
 [ext_resource type="Script" path="res://component/ui/input_prompts/prompt_container.gd" id="1_vo7iq"]
+[ext_resource type="Texture2D" uid="uid://b1e23gj3k1klg" path="res://addons/input_prompts/icons/xbox/a.png" id="2_xdg6b"]
 [ext_resource type="Script" path="res://addons/input_prompts/action_prompt/action_prompt.gd" id="3_ql8fw"]
+[ext_resource type="Texture2D" uid="uid://c6cv5phl3gvvn" path="res://addons/input_prompts/icons/xbox/right_trigger.png" id="4_akj72"]
+[ext_resource type="Texture2D" uid="uid://dx1u47qkx4in8" path="res://addons/input_prompts/icons/xbox/left_trigger.png" id="5_c14bx"]
+[ext_resource type="Texture2D" uid="uid://dv0r0pf7dwijj" path="res://addons/input_prompts/icons/xbox/b.png" id="6_04hns"]
+[ext_resource type="Texture2D" uid="uid://cah6r1q5x2lte" path="res://addons/input_prompts/icons/generic/left_stick_left.png" id="7_w11vb"]
+[ext_resource type="Texture2D" uid="uid://c03r3n0nfrjck" path="res://addons/input_prompts/icons/generic/left_stick_right.png" id="8_m6wya"]
 
-[sub_resource type="InputEventKey" id="InputEventKey_eyt6c"]
+[sub_resource type="InputEventKey" id="InputEventKey_jm5e5"]
 device = -1
 physical_keycode = 32
 unicode = 32
 
-[sub_resource type="InputEventJoypadButton" id="InputEventJoypadButton_3f2lm"]
+[sub_resource type="InputEventJoypadButton" id="InputEventJoypadButton_wj4uo"]
 device = -1
 
-[sub_resource type="InputEventJoypadMotion" id="InputEventJoypadMotion_tigyc"]
+[sub_resource type="InputEventJoypadMotion" id="InputEventJoypadMotion_8t453"]
 device = -1
 axis = 5
 axis_value = 1.0
 
-[sub_resource type="InputEventKey" id="InputEventKey_5dae6"]
+[sub_resource type="InputEventKey" id="InputEventKey_07cvw"]
 device = -1
 physical_keycode = 4194320
 
-[sub_resource type="InputEventJoypadMotion" id="InputEventJoypadMotion_hhdpk"]
+[sub_resource type="InputEventJoypadMotion" id="InputEventJoypadMotion_pn7hm"]
 device = -1
 axis = 4
 axis_value = 1.0
 
-[sub_resource type="InputEventKey" id="InputEventKey_6i01c"]
+[sub_resource type="InputEventKey" id="InputEventKey_7j6ii"]
 device = -1
 physical_keycode = 4194322
 
-[sub_resource type="InputEventMouseButton" id="InputEventMouseButton_6i2a8"]
+[sub_resource type="InputEventMouseButton" id="InputEventMouseButton_5tuqs"]
 device = -1
 button_mask = 1
 position = Vector2(95, 20)
@@ -37,30 +43,30 @@ global_position = Vector2(99, 63)
 button_index = 1
 pressed = true
 
-[sub_resource type="InputEventKey" id="InputEventKey_li2r7"]
+[sub_resource type="InputEventKey" id="InputEventKey_y1gwo"]
 device = -1
 physical_keycode = 69
 unicode = 46
 
-[sub_resource type="InputEventJoypadButton" id="InputEventJoypadButton_40xj1"]
+[sub_resource type="InputEventJoypadButton" id="InputEventJoypadButton_n7ufn"]
 device = -1
 button_index = 1
 
-[sub_resource type="InputEventKey" id="InputEventKey_vqhl2"]
+[sub_resource type="InputEventKey" id="InputEventKey_q4jus"]
 device = -1
 physical_keycode = 65
 unicode = 97
 
-[sub_resource type="InputEventJoypadMotion" id="InputEventJoypadMotion_l8a88"]
+[sub_resource type="InputEventJoypadMotion" id="InputEventJoypadMotion_oji7s"]
 device = -1
 axis_value = -1.0
 
-[sub_resource type="InputEventKey" id="InputEventKey_ghxeo"]
+[sub_resource type="InputEventKey" id="InputEventKey_fi2er"]
 device = -1
 physical_keycode = 68
 unicode = 101
 
-[sub_resource type="InputEventJoypadMotion" id="InputEventJoypadMotion_vm1od"]
+[sub_resource type="InputEventJoypadMotion" id="InputEventJoypadMotion_j1j4m"]
 device = -1
 axis_value = 1.0
 
@@ -82,20 +88,22 @@ text = "Accelerate"
 [node name="AccelerateMaxActionPrompt" type="TextureRect" parent="AcceleratePrompt"]
 custom_minimum_size = Vector2(100, 100)
 layout_mode = 2
+texture = ExtResource("2_xdg6b")
 stretch_mode = 5
 script = ExtResource("3_ql8fw")
 action = "main"
 icon = 0
-events = Array[InputEvent]([SubResource("InputEventKey_eyt6c"), SubResource("InputEventJoypadButton_3f2lm")])
+events = Array[InputEvent]([SubResource("InputEventKey_jm5e5"), SubResource("InputEventJoypadButton_wj4uo")])
 
 [node name="AccelerateAnalogActionPrompt" type="TextureRect" parent="AcceleratePrompt"]
 custom_minimum_size = Vector2(100, 100)
 layout_mode = 2
+texture = ExtResource("4_akj72")
 stretch_mode = 5
 script = ExtResource("3_ql8fw")
 action = "analog_main"
 icon = 0
-events = Array[InputEvent]([SubResource("InputEventJoypadMotion_tigyc"), SubResource("InputEventKey_5dae6")])
+events = Array[InputEvent]([SubResource("InputEventJoypadMotion_8t453"), SubResource("InputEventKey_07cvw")])
 
 [node name="ReversePrompt" type="HBoxContainer" parent="."]
 layout_mode = 2
@@ -110,11 +118,12 @@ text = "Reverse
 [node name="ReverseActionPrompt" type="TextureRect" parent="ReversePrompt"]
 custom_minimum_size = Vector2(100, 100)
 layout_mode = 2
+texture = ExtResource("5_c14bx")
 stretch_mode = 5
 script = ExtResource("3_ql8fw")
 action = "analog_secondary"
 icon = 0
-events = Array[InputEvent]([SubResource("InputEventJoypadMotion_hhdpk"), SubResource("InputEventKey_6i01c")])
+events = Array[InputEvent]([SubResource("InputEventJoypadMotion_pn7hm"), SubResource("InputEventKey_7j6ii")])
 
 [node name="BreakPrompt" type="HBoxContainer" parent="."]
 layout_mode = 2
@@ -129,11 +138,12 @@ text = "Break
 [node name="BreakActionPrompt" type="TextureRect" parent="BreakPrompt"]
 custom_minimum_size = Vector2(100, 100)
 layout_mode = 2
+texture = ExtResource("6_04hns")
 stretch_mode = 5
 script = ExtResource("3_ql8fw")
 action = "stop"
 icon = 0
-events = Array[InputEvent]([SubResource("InputEventMouseButton_6i2a8"), SubResource("InputEventKey_li2r7"), SubResource("InputEventJoypadButton_40xj1")])
+events = Array[InputEvent]([SubResource("InputEventMouseButton_5tuqs"), SubResource("InputEventKey_y1gwo"), SubResource("InputEventJoypadButton_n7ufn")])
 
 [node name="SteerPrompt" type="HBoxContainer" parent="."]
 layout_mode = 2
@@ -147,17 +157,19 @@ text = "Steer"
 [node name="SteerLeftActionPrompt" type="TextureRect" parent="SteerPrompt"]
 custom_minimum_size = Vector2(100, 100)
 layout_mode = 2
+texture = ExtResource("7_w11vb")
 stretch_mode = 5
 script = ExtResource("3_ql8fw")
 action = "move_left"
 icon = 0
-events = Array[InputEvent]([SubResource("InputEventKey_vqhl2"), SubResource("InputEventJoypadMotion_l8a88")])
+events = Array[InputEvent]([SubResource("InputEventKey_q4jus"), SubResource("InputEventJoypadMotion_oji7s")])
 
 [node name="SteerRightActionPrompt" type="TextureRect" parent="SteerPrompt"]
 custom_minimum_size = Vector2(100, 100)
 layout_mode = 2
+texture = ExtResource("8_m6wya")
 stretch_mode = 5
 script = ExtResource("3_ql8fw")
 action = "move_right"
 icon = 0
-events = Array[InputEvent]([SubResource("InputEventKey_ghxeo"), SubResource("InputEventJoypadMotion_vm1od")])
+events = Array[InputEvent]([SubResource("InputEventKey_fi2er"), SubResource("InputEventJoypadMotion_j1j4m")])

godot/component/ui/input_prompts/plane/plane_prompts.tscn

@@ -1,50 +1,55 @@
-[gd_scene load_steps=13 format=3 uid="uid://rixhldyytdiy"]
+[gd_scene load_steps=18 format=3 uid="uid://rixhldyytdiy"]
 
 [ext_resource type="Script" path="res://component/ui/input_prompts/prompt_container.gd" id="1_eppoy"]
+[ext_resource type="Texture2D" uid="uid://b1e23gj3k1klg" path="res://addons/input_prompts/icons/xbox/a.png" id="2_bfgq1"]
 [ext_resource type="Script" path="res://addons/input_prompts/action_prompt/action_prompt.gd" id="2_h1sqq"]
+[ext_resource type="Texture2D" uid="uid://cah6r1q5x2lte" path="res://addons/input_prompts/icons/generic/left_stick_left.png" id="4_8s3s4"]
+[ext_resource type="Texture2D" uid="uid://c03r3n0nfrjck" path="res://addons/input_prompts/icons/generic/left_stick_right.png" id="5_5ns3s"]
+[ext_resource type="Texture2D" uid="uid://dreirjfpqj40a" path="res://addons/input_prompts/icons/generic/left_stick_down.png" id="6_712bd"]
+[ext_resource type="Texture2D" uid="uid://bntsrcd3hjcex" path="res://addons/input_prompts/icons/generic/left_stick_up.png" id="7_awcyd"]
 
-[sub_resource type="InputEventKey" id="InputEventKey_eyt6c"]
+[sub_resource type="InputEventKey" id="InputEventKey_jm5e5"]
 device = -1
 physical_keycode = 32
 unicode = 32
 
-[sub_resource type="InputEventJoypadButton" id="InputEventJoypadButton_3f2lm"]
+[sub_resource type="InputEventJoypadButton" id="InputEventJoypadButton_wj4uo"]
 device = -1
 
-[sub_resource type="InputEventKey" id="InputEventKey_vqhl2"]
+[sub_resource type="InputEventKey" id="InputEventKey_q4jus"]
 device = -1
 physical_keycode = 65
 unicode = 97
 
-[sub_resource type="InputEventJoypadMotion" id="InputEventJoypadMotion_l8a88"]
+[sub_resource type="InputEventJoypadMotion" id="InputEventJoypadMotion_oji7s"]
 device = -1
 axis_value = -1.0
 
-[sub_resource type="InputEventKey" id="InputEventKey_ghxeo"]
+[sub_resource type="InputEventKey" id="InputEventKey_fi2er"]
 device = -1
 physical_keycode = 68
 unicode = 101
 
-[sub_resource type="InputEventJoypadMotion" id="InputEventJoypadMotion_vm1od"]
+[sub_resource type="InputEventJoypadMotion" id="InputEventJoypadMotion_j1j4m"]
 device = -1
 axis_value = 1.0
 
-[sub_resource type="InputEventKey" id="InputEventKey_fvypa"]
+[sub_resource type="InputEventKey" id="InputEventKey_35cri"]
 device = -1
 physical_keycode = 83
 unicode = 111
 
-[sub_resource type="InputEventJoypadMotion" id="InputEventJoypadMotion_f34ba"]
+[sub_resource type="InputEventJoypadMotion" id="InputEventJoypadMotion_ekkas"]
 device = -1
 axis = 1
 axis_value = 1.0
 
-[sub_resource type="InputEventKey" id="InputEventKey_c4xy3"]
+[sub_resource type="InputEventKey" id="InputEventKey_knka0"]
 device = -1
 physical_keycode = 87
 unicode = 44
 
-[sub_resource type="InputEventJoypadMotion" id="InputEventJoypadMotion_th7as"]
+[sub_resource type="InputEventJoypadMotion" id="InputEventJoypadMotion_7mrea"]
 device = -1
 axis = 1
 axis_value = -1.0
@@ -67,11 +72,12 @@ text = "Accelerate"
 [node name="AccelerateMaxActionPrompt" type="TextureRect" parent="AcceleratePrompt"]
 custom_minimum_size = Vector2(100, 100)
 layout_mode = 2
+texture = ExtResource("2_bfgq1")
 stretch_mode = 5
 script = ExtResource("2_h1sqq")
 action = "main"
 icon = 0
-events = Array[InputEvent]([SubResource("InputEventKey_eyt6c"), SubResource("InputEventJoypadButton_3f2lm")])
+events = Array[InputEvent]([SubResource("InputEventKey_jm5e5"), SubResource("InputEventJoypadButton_wj4uo")])
 
 [node name="RollPrompt" type="HBoxContainer" parent="."]
 layout_mode = 2
@@ -85,20 +91,22 @@ text = "Roll"
 [node name="RollLeftActionPrompt" type="TextureRect" parent="RollPrompt"]
 custom_minimum_size = Vector2(100, 100)
 layout_mode = 2
+texture = ExtResource("4_8s3s4")
 stretch_mode = 5
 script = ExtResource("2_h1sqq")
 action = "move_left"
 icon = 0
-events = Array[InputEvent]([SubResource("InputEventKey_vqhl2"), SubResource("InputEventJoypadMotion_l8a88")])
+events = Array[InputEvent]([SubResource("InputEventKey_q4jus"), SubResource("InputEventJoypadMotion_oji7s")])
 
 [node name="RollRightActionPrompt" type="TextureRect" parent="RollPrompt"]
 custom_minimum_size = Vector2(100, 100)
 layout_mode = 2
+texture = ExtResource("5_5ns3s")
 stretch_mode = 5
 script = ExtResource("2_h1sqq")
 action = "move_right"
 icon = 0
-events = Array[InputEvent]([SubResource("InputEventKey_ghxeo"), SubResource("InputEventJoypadMotion_vm1od")])
+events = Array[InputEvent]([SubResource("InputEventKey_fi2er"), SubResource("InputEventJoypadMotion_j1j4m")])
 
 [node name="PitchPrompt" type="HBoxContainer" parent="."]
 layout_mode = 2
@@ -112,17 +120,19 @@ text = "Roll"
 [node name="PitchUpActionPrompt" type="TextureRect" parent="PitchPrompt"]
 custom_minimum_size = Vector2(100, 100)
 layout_mode = 2
+texture = ExtResource("6_712bd")
 stretch_mode = 5
 script = ExtResource("2_h1sqq")
 action = "move_back"
 icon = 0
-events = Array[InputEvent]([SubResource("InputEventKey_fvypa"), SubResource("InputEventJoypadMotion_f34ba")])
+events = Array[InputEvent]([SubResource("InputEventKey_35cri"), SubResource("InputEventJoypadMotion_ekkas")])
 
 [node name="PitchDownActionPrompt" type="TextureRect" parent="PitchPrompt"]
 custom_minimum_size = Vector2(100, 100)
 layout_mode = 2
+texture = ExtResource("7_awcyd")
 stretch_mode = 5
 script = ExtResource("2_h1sqq")
 action = "move_forward"
 icon = 0
-events = Array[InputEvent]([SubResource("InputEventKey_c4xy3"), SubResource("InputEventJoypadMotion_th7as")])
+events = Array[InputEvent]([SubResource("InputEventKey_knka0"), SubResource("InputEventJoypadMotion_7mrea")])

godot/component/ui/input_prompts/prompt_container.gd

@@ -16,6 +16,25 @@ func _ready() -> void:
 			_nb_prompts += 1
 
 
+func switch(enable: bool) -> void:
+	if enable:
+		enable()
+	else:
+		disable()
+
+
+# Show and process
+func enable() -> void:
+	set_visible(true)
+	set_process_mode(Node.PROCESS_MODE_PAUSABLE)
+
+
+# Hide and stop processing
+func disable() -> void:
+	set_visible(false)
+	set_process_mode(Node.PROCESS_MODE_DISABLED)
+
+
 func remove_if_no_more_prompt():
 	_nb_prompts -= 1
 	print(_nb_prompts, " remaining prompts")

godot/run/levels/infinite_level.tscn

@@ -458,9 +458,11 @@ script = ExtResource("15_k0ijo")
 
 [node name="InputPromptsCollection" type="VBoxContainer" parent="UI/InputPromptsCenter"]
 layout_mode = 2
+script = ExtResource("22_tmm3q")
 
 [node name="WalkPrompts" type="VBoxContainer" parent="UI/InputPromptsCenter/InputPromptsCollection"]
 layout_mode = 2
+script = ExtResource("22_tmm3q")
 
 [node name="MovePrompt" parent="UI/InputPromptsCenter/InputPromptsCollection/WalkPrompts" instance=ExtResource("15_wc547")]
 layout_mode = 2
@@ -475,6 +477,7 @@ layout_mode = 2
 [node name="VehiclePrompts" type="VBoxContainer" parent="UI/InputPromptsCenter/InputPromptsCollection"]
 visible = false
 layout_mode = 2
+script = ExtResource("22_tmm3q")
 
 [node name="JeepPrompts" parent="UI/InputPromptsCenter/InputPromptsCollection/VehiclePrompts" instance=ExtResource("21_wa45u")]
 layout_mode = 2